[Spark-20873][SQL] Improve the error message for unsupported Column Type #18097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
Test build #77340 has started for PR 18097 at commit |
gatorsmile
reviewed
May 25, 2017
| test("show type name in type mismatch error") { | ||
| val invalidType = new DataType { | ||
| override def defaultSize: Int = 1 | ||
| override private[spark] def asNullable: DataType = null |
gatorsmile
reviewed
May 25, 2017
| @@ -684,7 +684,7 @@ private[columnar] object ColumnType { | |||
| case struct: StructType => STRUCT(struct) | |||
| case udt: UserDefinedType[_] => apply(udt.sqlType) | |||
| case other => | |||
| throw new Exception(s"Unsupported type: $other") | |||
| throw new Exception(s"Unsupported type: ${other.typeName}") | |||
|
Test build #77377 has finished for PR 18097 at commit
|
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upon encountering an invalid columntype, the column type object is printed, rather than the type.
This change improves this by outputting its name.
How was this patch tested?
Added a simple unit test to verify the contents of the raised exception