[SPARK-16019][yarn] Use separate RM poll interval when starting client AM. #18380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t AM. Currently the code monitoring the launch of the client AM uses the value of spark.yarn.report.interval as the interval for polling the RM; if someone has that value to a really large interval, it would take that long to detect that the client AM has started, which is not expected. Instead, have a separate config for the interval to use when the client AM is starting. The other config is still used in cluster mode, and to detect the status of the client AM after it is already running. Tested by running client and cluster mode apps with a modified value of spark.yarn.report.interval, verifying client AM launch is detected before that interval elapses.
|
Test build #78406 has finished for PR 18380 at commit
|
tgravescs
reviewed
Jul 10, 2017
| logApplicationReport: Boolean = true): (YarnApplicationState, FinalApplicationStatus) = { | ||
| val interval = sparkConf.get(REPORT_INTERVAL) | ||
| logApplicationReport: Boolean = true, | ||
| interval: Long = sparkConf.get(REPORT_INTERVAL)): |
There was a problem hiding this comment.
add new param to method description
|
Test build #79475 has finished for PR 18380 at commit
|
tgravescs
reviewed
Jul 10, 2017
| .timeConf(TimeUnit.MILLISECONDS) | ||
| .createWithDefaultString("1s") | ||
|
|
||
| private[spark] val CLIENT_LAUNCH_MONITOR_INTERVAL = | ||
| ConfigBuilder("spark.yarn.am.launchMonitorInterval") |
There was a problem hiding this comment.
sorry missed this in my first pass. One thing here is that normally the spark.yarn.am. configs are configs that apply to the am, this one is slightly different in that its how often the client pulls the am for status (applies more to the client). We aren't documenting it anyway but perhaps we should name something like spark.yarn.clientAMLaunchMonitorInterval?
|
Test build #79478 has finished for PR 18380 at commit
|
|
+1, feel free to commit |
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code monitoring the launch of the client AM uses the value of
spark.yarn.report.interval as the interval for polling the RM; if someone
has that value to a really large interval, it would take that long to detect
that the client AM has started, which is not expected.
Instead, have a separate config for the interval to use when the client AM is
starting. The other config is still used in cluster mode, and to detect the
status of the client AM after it is already running.
Tested by running client and cluster mode apps with a modified value of
spark.yarn.report.interval, verifying client AM launch is detected before
that interval elapses.