[SPARK-21478][SQL] Avoid unpersisting related Datasets #18771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
reviewed
Jul 29, 2017
| */ | ||
| def uncacheQuery(spark: SparkSession, plan: LogicalPlan, blocking: Boolean): Unit = writeLock { | ||
| val it = cachedData.iterator() | ||
| while (it.hasNext) { | ||
| val cd = it.next() | ||
| if (cd.plan.find(_.sameResult(plan)).isDefined) { | ||
| if (plan.sameResult(cd.plan)) { |
There was a problem hiding this comment.
This is by design. This is for avoiding to get the incorrect results. See the original PR: #17097
There was a problem hiding this comment.
@gatorsmile Thanks for the update.
I'll close this PR
|
Test build #80046 has finished for PR 18771 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While unpersisting a dataset, only unpersist and remove that datasets's plan from Cachemanager's cachedData.
How was this patch tested?
Added unit tests