-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-21720][SQL] Fix 64KB JVM bytecode limit problem with AND or OR #18972
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2067,7 +2067,7 @@ class DataFrameSuite extends QueryTest with SharedSQLContext { | |
.count | ||
} | ||
|
||
testQuietly("SPARK-19372: Filter can be executed w/o generated code due to JVM code size limit") { | ||
test("SPARK-19372: Filter can be executed w/o generated code due to JVM code size limit") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this test case becomes invalid as we won't trigger the codegen fallback branch now. Can we just ignore this test and add a TODO to say something about the config? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see. I will do it on Sunday. |
||
val N = 400 | ||
val rows = Seq(Row.fromSeq(Seq.fill(N)("string"))) | ||
val schema = StructType(Seq.tabulate(N)(i => StructField(s"_c$i", StringType))) | ||
|
@@ -2081,10 +2081,8 @@ class DataFrameSuite extends QueryTest with SharedSQLContext { | |
} | ||
|
||
withSQLConf(SQLConf.CODEGEN_FALLBACK.key -> "false") { | ||
val e = intercept[SparkException] { | ||
df.filter(filter).count() | ||
}.getMessage | ||
assert(e.contains("grows beyond 64 KB")) | ||
// SPARK-21720 avoids an exception due to JVM code size limit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should create a config for the threshold instead of hardcoding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In general, I agree with you that we should create a config. Can we introduce a config after fixing active session management? |
||
df.filter(filter).count() | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it work with whole stage codegen? the input is not
InternalRow
but some variable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works only if
ctx.currentVars == null
.We will follow to support the whole stage codegen as follow-up in other PRs.