[SPARK-21837][SQL][TESTS] UserDefinedTypeSuite Local UDTs not actually testing what it intends #19053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
referenced
this pull request
Aug 25, 2017
## What changes were proposed in this pull request? Enable ScalaReflection and User Defined Types for plain Scala classes. This involves the move of `schemaFor` from `ScalaReflection` trait (which is Runtime and Compile time (macros) reflection) to the `ScalaReflection` object (runtime reflection only) as I believe this code wouldn't work at compile time anyway as it manipulates `Class`'s that are not compiled yet. ## How was this patch tested? Unit test Author: Joan <joan@goyeau.com> Closes #12149 from joan38/SPARK-13929-Scala-reflection.
srowen
commented
Aug 25, 2017
| val df = Seq((1, vec)).toDF("int", "vec") | ||
| assert(vec === df.collect()(0).getAs[UDT.MyDenseVector](1)) | ||
| assert(vec === df.take(1)(0).getAs[UDT.MyDenseVector](1)) | ||
| assert(vec === df.limit(1).groupBy('int).agg(first('vec)).collect()(0) |
There was a problem hiding this comment.
Note that this and the next line fails with the assert added, if it is left dereferencing col 0 at the end instead of 1.
There was a problem hiding this comment.
Since the last two lines are not testing collect, we can rewrite them to
checkAnswer(df.limit(1).groupBy('int).agg(first('vec)), Row(1, vec))
checkAnswer(df.orderBy('int).limit(1).groupBy('int).agg(first('vec)), Row(1, vec))
|
Test build #81130 has finished for PR 19053 at commit
|
|
UDF? |
|
Oops, I meant UDT. Just referring to the tests name in the code. |
srowen
changed the title
|
LGTM except one comment. |
|
Test build #3903 has finished for PR 19053 at commit
|
|
LGTM |
|
Test build #81137 has finished for PR 19053 at commit
|
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adjust Local UDTs test to assert about results, and fix index of vector column. See JIRA for details.
How was this patch tested?
Existing tests.