Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21884] [BACKPORT-2.2] [SPARK-21477] [SQL] Mark LocalTableScanExec's input data transient #19101

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

This PR is to backport #18686 for resolving the issue in #19094


What changes were proposed in this pull request?

This PR is to mark the parameter rows and unsafeRow of LocalTableScanExec transient. It can avoid serializing the unneeded objects.

How was this patch tested?

N/A

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.
Thank you for adding the test case, too.

@SparkQA
Copy link

SparkQA commented Sep 1, 2017

Test build #81302 has finished for PR 19101 at commit 3ee18ce.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

Thanks! Merged to 2.2

asfgit pushed a commit that referenced this pull request Sep 1, 2017
…'s input data transient

This PR is to backport #18686 for resolving the issue in #19094

---

## What changes were proposed in this pull request?
This PR is to mark the parameter `rows` and `unsafeRow` of LocalTableScanExec transient. It can avoid serializing the unneeded objects.

## How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes #19101 from gatorsmile/backport-21477.
@dongjoon-hyun
Copy link
Member

Thank YOU!

@gatorsmile gatorsmile closed this Sep 1, 2017
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
…'s input data transient

This PR is to backport apache#18686 for resolving the issue in apache#19094

---

## What changes were proposed in this pull request?
This PR is to mark the parameter `rows` and `unsafeRow` of LocalTableScanExec transient. It can avoid serializing the unneeded objects.

## How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes apache#19101 from gatorsmile/backport-21477.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants