Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21477] [SQL] [MINOR] Mark LocalTableScanExec's input data transient #18686

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Jul 19, 2017

What changes were proposed in this pull request?

This PR is to mark the parameter rows and unsafeRow of LocalTableScanExec transient. It can avoid serializing the unneeded objects.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @cloud-fan

@gatorsmile gatorsmile changed the title [SQL] [MINOR] Mark LocalTableScanExec's input data transient [SPARK-21477] [SQL] [MINOR] Mark LocalTableScanExec's input data transient Jul 19, 2017
@SparkQA
Copy link

SparkQA commented Jul 19, 2017

Test build #79777 has finished for PR 18686 at commit 662d377.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM, merging to master!

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 31, 2017

Oh, @gatorsmile .
I didn't find the right this fix.
Could you backport this to branch-2.2, too?

@dongjoon-hyun
Copy link
Member

I'm testing now.

@dongjoon-hyun
Copy link
Member

Yes. This is the fix.
@gatorsmile and @cloud-fan . Can we have this in branch-2.2, too?

@gatorsmile
Copy link
Member Author

Sure. Will do it.

@dongjoon-hyun
Copy link
Member

Thank you so much!

asfgit pushed a commit that referenced this pull request Sep 1, 2017
…'s input data transient

This PR is to backport #18686 for resolving the issue in #19094

---

## What changes were proposed in this pull request?
This PR is to mark the parameter `rows` and `unsafeRow` of LocalTableScanExec transient. It can avoid serializing the unneeded objects.

## How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes #19101 from gatorsmile/backport-21477.
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
…'s input data transient

This PR is to backport apache#18686 for resolving the issue in apache#19094

---

## What changes were proposed in this pull request?
This PR is to mark the parameter `rows` and `unsafeRow` of LocalTableScanExec transient. It can avoid serializing the unneeded objects.

## How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes apache#19101 from gatorsmile/backport-21477.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants