Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2468] Netty based block server / client module #1971

Closed
wants to merge 6 commits into from
Closed

[SPARK-2468] Netty based block server / client module #1971

wants to merge 6 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Aug 15, 2014

Previous pull request (#1907) was reverted. This brings it back. Still looking into the hang.

@rxin
Copy link
Contributor Author

rxin commented Aug 15, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 15, 2014

QA tests have started for PR 1971 at commit 9629a1e.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

Jenkins, retest this please.

@rxin
Copy link
Contributor Author

rxin commented Aug 16, 2014

I haven't actually made any change since we reverted it, so expecting this to timeout.

@pwendell
Copy link
Contributor

yeah I wanted to test our new timeout code - but since it doesn't merge cleanly it won't test it anyways :P

@SparkQA
Copy link

SparkQA commented Aug 16, 2014

QA tests have started for PR 1971 at commit 9629a1e.

  • This patch does not merge cleanly!

@rxin
Revert "Revert "[SPARK-2468] Netty based block server / client module""
db6e6e0 
This reverts commit fd9fcd2, which was a revert. That is to say, this added Netty module back.
@rxin
Remove netty-test-file.txt.
002626a 
(cherry picked from commit 3debe7c)
Signed-off-by: Reynold Xin <rxin@apache.org>
@rxin
Copy link
Contributor Author

rxin commented Aug 16, 2014

Ok I pushed a new version that merges cleanly. You should be able to use this to test.

@SparkQA
Copy link

SparkQA commented Aug 16, 2014

QA tests have started for PR 1971 at commit 002626a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 16, 2014

Tests timed out after a configured wait of 120m.

@rxin
Copy link
Contributor Author

rxin commented Aug 19, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 1971 at commit 002626a.

  • This patch merges cleanly.

@rxin
Copy link
Contributor Author

rxin commented Aug 19, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 1971 at commit 603dce7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 1971 at commit 603dce7.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Aug 19, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 1971 at commit 603dce7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 1971 at commit 603dce7.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Aug 19, 2014

Jenkins, retest this please.

@rxin
Copy link
Contributor Author

rxin commented Aug 19, 2014

There is some residual file from previous test runs that are failing the pull request builder.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 1971 at commit 603dce7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

Tests timed out after a configured wait of 120m.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 1971 at commit 603dce7.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Aug 19, 2014

Ok I pushed a new version that no longer hangs tests

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 1971 at commit 4c6d0ee.

  • This patch merges cleanly.

@shivaram
Copy link
Contributor

What was the bug that caused tests to hang ?

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 1971 at commit 4c6d0ee.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Aug 19, 2014

@shivaram a problem introduced by a specific version of Netty: https://groups.google.com/forum/#!topic/netty/4kYi0wsCPxA

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 1971 at commit b0be96f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have finished for PR 1971 at commit b0be96f.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

Tests pass ! LGTM

asfgit pushed a commit that referenced this pull request Aug 20, 2014
@rxin
[SPARK-2468] Netty based block server / client module
66b4c81 
Previous pull request (#1907) was reverted. This brings it back. Still looking into the hang.

Author: Reynold Xin <rxin@apache.org>

Closes #1971 from rxin/netty1 and squashes the following commits:

b0be96f [Reynold Xin] Added test to make sure outstandingRequests are cleaned after firing the events.
4c6d0ee [Reynold Xin] Pass callbacks cleanly.
603dce7 [Reynold Xin] Upgrade Netty to 4.0.23 to fix the DefaultFileRegion bug.
88be1d4 [Reynold Xin] Downgrade to 4.0.21 to work around a bug in writing DefaultFileRegion.
002626a [Reynold Xin] Remove netty-test-file.txt.
db6e6e0 [Reynold Xin] Revert "Revert "[SPARK-2468] Netty based block server / client module""

(cherry picked from commit 8b9dc99)
Signed-off-by: Reynold Xin <rxin@apache.org>
@rxin
Copy link
Contributor Author

rxin commented Aug 20, 2014

Thanks. I merged it in master and branch-1.1. Hopefully this time it won't hang tests in the future.

@asfgit asfgit closed this in 8b9dc99 Aug 20, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@rxin @conviva-zz
[SPARK-2468] Netty based block server / client module
f96aacb 
Previous pull request (apache#1907) was reverted. This brings it back. Still looking into the hang.

Author: Reynold Xin <rxin@apache.org>

Closes apache#1971 from rxin/netty1 and squashes the following commits:

b0be96f [Reynold Xin] Added test to make sure outstandingRequests are cleaned after firing the events.
4c6d0ee [Reynold Xin] Pass callbacks cleanly.
603dce7 [Reynold Xin] Upgrade Netty to 4.0.23 to fix the DefaultFileRegion bug.
88be1d4 [Reynold Xin] Downgrade to 4.0.21 to work around a bug in writing DefaultFileRegion.
002626a [Reynold Xin] Remove netty-test-file.txt.
db6e6e0 [Reynold Xin] Revert "Revert "[SPARK-2468] Netty based block server / client module""
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Aug 7, 2024
@parthchandra
rdar://128712777 Bump callhome version to 0.2.35 (apache#1971)
c5a210b 
* rdar://128242495 Enable extended explain info from Boson

* Update to callhome 0.2.35

(cherry picked from commit f403b6598410f07d8ee9769f31e3d261657970d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rxin @SparkQA @pwendell @shivaram