Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-22572] [Spark shell] spark-shell does not re-initialize on :replay #19791

Closed
wants to merge 3 commits into from
Closed

[SPARK-22572] [Spark shell] spark-shell does not re-initialize on :replay #19791

wants to merge 3 commits into from

Conversation

mpetruska
Copy link
Contributor

What changes were proposed in this pull request?

Ticket: SPARK-22572

How was this patch tested?

Added a new test case to org.apache.spark.repl.ReplSuite

srowen
srowen approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, OK if that works that looks good.

@SparkQA
Copy link

SparkQA commented Nov 21, 2017

Test build #3989 has finished for PR 19791 at commit 3e8e274.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon
HyukjinKwon approved these changes Nov 22, 2017
View reviewed changes
repl/src/test/scala/org/apache/spark/repl/ReplSuite.scala Outdated
"""
|sc
|:replay
""".stripMargin) should not include "error: not found: value sc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just use assert... instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, updated the test case; also removed Matchers as this was the only matcher used.

@HyukjinKwon
Copy link
Member

test this please

@SparkQA
Copy link

SparkQA commented Nov 22, 2017

Test build #84103 has finished for PR 19791 at commit aba0066.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ReplSuite extends SparkFunSuite

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Nov 22, 2017 •
edited
Loading

Hm, wait. Please give me some minutes.

@HyukjinKwon
Copy link
Member

LGTM

@HyukjinKwon
Copy link
Member

Merged to master.

@asfgit asfgit closed this in 327d25f Nov 22, 2017
@mpetruska mpetruska deleted the SPARK-22572 branch November 22, 2017 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpetruska @SparkQA @HyukjinKwon @srowen