-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-22274][PYTHON][SQL] User-defined aggregation functions with pandas udf (full shuffle) #19872
Closed
Closed
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
692b54f
Initial commit: wip
icexelloss 11321f6
wip
icexelloss 8cf0ccd
Tests pass
icexelloss c1f6cf9
Clean up
icexelloss 3791b28
More clean up
icexelloss df9f6b3
more clean up
icexelloss 58c21c1
Clean up code; Address PR comments
icexelloss d79464c
Fix python style
icexelloss 51f4782
Add docs and more tests
icexelloss 505acdb
Style fix
icexelloss 4856e82
Remove whitespace
icexelloss 3287e6e
Fix doctest
icexelloss 7dcdd3a
Tests pass
icexelloss 1c834f7
Fix merge error
icexelloss 066783e
Fix test
icexelloss cd16485
Add complex_grouping test
icexelloss 959f3eb
Address PR comments
icexelloss 3cda9b8
Remove ExtractGroupAggPandasUDFFromAggregate
icexelloss 1696bdb
Fix style
icexelloss 4e713a4
Add doctest SKIP for passing build with pypy
icexelloss a89416f
Fix incorrect doctest SKIP
icexelloss 4253caa
Add docs for AggregateInPandasExec
icexelloss f91d9ba
Address PR comments
icexelloss 9085ca6
Address PR comments
icexelloss ebc49cc
Minor style change
icexelloss bf084ff
Fix error message]
icexelloss 7745b0a
Fix Streaming aggregation check
icexelloss cf9e7dc
Minor style fix
icexelloss 6d505d3
Minor style fix
icexelloss 8d2d943
Revert accidental removal
icexelloss 17fad5c
Fix docs. Address PR comments.
icexelloss 0fec5cf
Fix SparkStrategies
icexelloss 4d22107
Add a manual test
icexelloss 91885e5
Address comments
icexelloss cc659bc
Add doctest SKIP
icexelloss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm worried that it isn't clear to the user that this will result in a full-shuffle with no-partial aggregation. Is there maybe a place we can document this warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in docstring of
pandas_udf
andgroupby().agg()