Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some shuffle configurations in doc #2031

Closed
wants to merge 5 commits into from

Conversation

CrazyJvm
Copy link
Contributor

add some shuffle configurations into documentation

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 2031 at commit 8ad9955.

  • This patch merges cleanly.

@CrazyJvm CrazyJvm changed the title add spark.shuffle.spill.batchSize and fix the value of spark.shuffle.manager add some shuffle configurations in doc and fix bug Aug 19, 2014
@CrazyJvm CrazyJvm changed the title add some shuffle configurations in doc and fix bug add some shuffle configurations in doc Aug 19, 2014
@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 2031 at commit 876256d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 2031 at commit 8ad9955.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 2031 at commit 876256d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@colorant
Copy link
Contributor

the config value is case irrelevant , if you notice that there is a toLowerCase transform later ;)

@CrazyJvm
Copy link
Contributor Author

@colorant thanks, I've not noticed toLowerCase before : ) . already modified

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have started for PR 2031 at commit 181c512.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have finished for PR 2031 at commit 181c512.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have started for PR 2031 at commit 117e9bf.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have finished for PR 2031 at commit 117e9bf.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mateiz
Copy link
Contributor

mateiz commented Aug 26, 2014

Looks pretty cool, though I'll have to try it out. One thing: please add D3's license to our LICENSE and NOTICE files, similar to how we've included Boostrap and jquery.

@SparkQA
Copy link

SparkQA commented Sep 6, 2014

QA tests have started for PR 2031 at commit 117e9bf.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 6, 2014

QA tests have finished for PR 2031 at commit 117e9bf.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

/cc @aarondav @andrewor14, is this a configuration that we want to document?

@andrewor14
Copy link
Contributor

Hey @CrazyJvm I believe these options are intentionally left undocumented. These are fairly advanced settings that are meant to provide a backdoor in case the default value turns out to be erroneous, which doesn't seem to be the case. There is also an equivalent spark.storage.safetyFraction that we do not document for the same reason.

I would recommend that we close this issue.

@asfgit asfgit closed this in 534f24b Dec 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants