Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23169][INFRA][R] Run lintr on the changes of lint-r script and .lintr configuration #20339

Closed
wants to merge 3 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jan 21, 2018

What changes were proposed in this pull request?

When running the run-tests script, seems we don't run lintr on the changes of lint-r script and .lintr configuration.

How was this patch tested?

Jenkins builds

@HyukjinKwon HyukjinKwon changed the title [WIP] Run lintr on the changes of lint-r script and .lintr configuration [SPARK-23169][INFRA][R] Run lintr on the changes of lint-r script and .lintr configuration Jan 21, 2018
@HyukjinKwon
Copy link
Member Author

This was tested:

  1. fe59c8a intentionally added some changes in .lintr and lint-r to see if triggers the lint: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86430/console

  2. Added the detection logic to check if it triggers the lintr: 12789c7 - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86431/console

  3. Reverted the change of 1. back to leave only 2. change in this PR.

cc @felixcheung and @JoshRosen, could you take a look please?

@SparkQA
Copy link

SparkQA commented Jan 21, 2018

Test build #86430 has finished for PR 20339 at commit fe59c8a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2018

Test build #86431 has finished for PR 20339 at commit 12789c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2018

Test build #86432 has finished for PR 20339 at commit 5ca17ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Merged to master.

@HyukjinKwon
Copy link
Member Author

Thanks for reviewing this @felixcheung and @srowen.

@asfgit asfgit closed this in 12faae2 Jan 22, 2018
@HyukjinKwon HyukjinKwon deleted the check-r-changed branch October 16, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants