Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-23169][INFRA][R] Run lintr on the changes of lint-r script and .lintr configuration #20339

Closed
wants to merge 3 commits into from
Closed

[SPARK-23169][INFRA][R] Run lintr on the changes of lint-r script and .lintr configuration #20339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe59c8a
Double check if it really doesn't run the style check
HyukjinKwon Jan 21, 2018
12789c7
Run lintr on the changes of lint-r script and .lintr configuration
HyukjinKwon Jan 21, 2018
5ca17ac
Revert "Double check if it really doesn't run the style check"
HyukjinKwon Jan 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion dev/run-tests.py
View file
Open in desktop
Expand Up @@ -578,7 +578,10 @@ def main():
pass
if not changed_files or any(f.endswith(".py") for f in changed_files):
run_python_style_checks()
if not changed_files or any(f.endswith(".R") for f in changed_files):
if not changed_files or any(f.endswith(".R")
or f.endswith("lint-r")
or f.endswith(".lintr")
for f in changed_files):
run_sparkr_style_checks()

# determine if docs were changed and if we're inside the amplab environment
Expand Down