[SPARK-23259][SQL] Clean up legacy code around hive external catalog and HiveClientImpl #20425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengdb
changed the title
|
Test build #86777 has finished for PR 20425 at commit
|
gatorsmile
reviewed
Jan 30, 2018
| @@ -817,7 +821,6 @@ private[hive] class HiveClientImpl( | |||
| uri.toURL | |||
| } | |||
| clientLoader.addJar(jarURL) | |||
| runSqlHive(s"ADD JAR $path") | |||
There was a problem hiding this comment.
Let us create a separate PR for this line? The others look good to me.
|
I opened a PR addressing @gatorsmile's comments above since the author looks inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Three legacy statements are removed by this patch:
in HiveExternalCatalog: The
withClientwrapper is not necessary for the private methodgetRawTable.in HiveClientImpl: The statement
runSqlHive()is not necessary for theaddJarmethod, after the jar being added to the single class loader.in HiveClientImpl: There are some redundant code in both the
tableExistsandgetTableOptionmethod.How was this patch tested?
Existing tests
Please review http://spark.apache.org/contributing.html before opening a pull request.