[SPARK-23259][SQL] Clean up legacy code around hive external catalog and HiveClientImpl #21780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gatorsmile, mind taking a look please? |
gatorsmile
reviewed
Jul 16, 2018
|
Yup, please do. |
|
Test build #93075 has finished for PR 21780 at commit
|
|
retest this please |
|
Test build #93084 has finished for PR 21780 at commit
|
|
retest this please |
|
Test build #93095 has finished for PR 21780 at commit
|
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Three legacy statements are removed by this patch:
in HiveExternalCatalog: The withClient wrapper is not necessary for the private method getRawTable.
in HiveClientImpl: There are some redundant code in both the tableExists and getTableOption method.
This PR takes over #20425
How was this patch tested?
Existing tests
Closes #20425