Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3142][MLLIB] output shuffle data directly in Word2Vec #2049

Closed
wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Aug 20, 2014

Sorry I didn't realize this in #2043. @Ishiihara

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have started for PR 2049 at commit 050b1c5.

  • This patch merges cleanly.

@Ishiihara
Copy link
Contributor

Good point. This reduces the needs of temp object to store the output model and flatten removes none.

@SparkQA
Copy link

SparkQA commented Aug 20, 2014

QA tests have finished for PR 2049 at commit 050b1c5.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor Author

mengxr commented Aug 20, 2014

@Ishiihara Thanks for reviewing the code! I've merged this into master and branch-1.1.

asfgit pushed a commit that referenced this pull request Aug 20, 2014
Sorry I didn't realize this in #2043. Ishiihara

Author: Xiangrui Meng <meng@databricks.com>

Closes #2049 from mengxr/more-w2v and squashes the following commits:

050b1c5 [Xiangrui Meng] output shuffle data directly

(cherry picked from commit 0a984aa)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 0a984aa Aug 20, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Sorry I didn't realize this in apache#2043. Ishiihara

Author: Xiangrui Meng <meng@databricks.com>

Closes apache#2049 from mengxr/more-w2v and squashes the following commits:

050b1c5 [Xiangrui Meng] output shuffle data directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants