Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23417][python] Fix the build instructions supplied by exception messages in python streaming tests #20638

Closed
wants to merge 2 commits into from

Conversation

bersprockets
Copy link
Contributor

What changes were proposed in this pull request?

Fix the build instructions supplied by exception messages in python streaming tests.

I also added -DskipTests to the maven instructions to avoid the 170 minutes of scala tests that occurs each time one wants to add a jar to the assembly directory.

How was this patch tested?

  • clone branch
  • run build/sbt package
  • run python/run-tests --modules "pyspark-streaming" , expect error message
  • follow instructions in error message. i.e., run build/sbt assembly/package streaming-kafka-0-8-assembly/assembly
  • rerun python tests, expect error message
  • follow instructions in error message. i.e run build/sbt -Pflume assembly/package streaming-flume-assembly/assembly
  • rerun python tests, see success.
  • repeated all of the above for mvn version of the process.

@HyukjinKwon
Copy link
Member

ok to test

@HyukjinKwon
Copy link
Member

add to whitelist

@SparkQA
Copy link

SparkQA commented Feb 19, 2018

Test build #87545 has finished for PR 20638 at commit 8241313.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@bersprockets
Copy link
Contributor Author

Do we want to merge this or does it need more eyes?

@HyukjinKwon
Copy link
Member

Merged to master.

@bersprockets
Copy link
Contributor Author

@HyukjinKwon Oh, thanks. I guess I learned what "approved these changes" means.

@asfgit asfgit closed this in 23ac3aa Feb 28, 2018
@bersprockets bersprockets deleted the SPARK-23417_propa branch March 5, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants