[SPARK-23670][SQL] Fix memory leak on SparkPlanGraphWrapper #20813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
Test build #88210 has finished for PR 20813 at commit
|
|
Test build #88232 has finished for PR 20813 at commit
|
vanzin
reviewed
Mar 16, 2018
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusStore.scala
Show resolved
Hide resolved
|
I forgot to publish my comment above when I looked at this 2 days ago, so I'll fix it during merge. Merging to master / 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2018
Clean up SparkPlanGraphWrapper objects from InMemoryStore together with cleaning up SQLExecutionUIData existing unit test was extended to check also SparkPlanGraphWrapper object count vanzin Author: myroslavlisniak <acnipin@gmail.com> Closes #20813 from myroslavlisniak/master. (cherry picked from commit c2632ed) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
mstewart141
pushed a commit
to mstewart141/spark
that referenced
this pull request
Mar 24, 2018
Clean up SparkPlanGraphWrapper objects from InMemoryStore together with cleaning up SQLExecutionUIData existing unit test was extended to check also SparkPlanGraphWrapper object count vanzin Author: myroslavlisniak <acnipin@gmail.com> Closes apache#20813 from myroslavlisniak/master.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
Clean up SparkPlanGraphWrapper objects from InMemoryStore together with cleaning up SQLExecutionUIData existing unit test was extended to check also SparkPlanGraphWrapper object count vanzin Author: myroslavlisniak <acnipin@gmail.com> Closes apache#20813 from myroslavlisniak/master. (cherry picked from commit c2632ed) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clean up SparkPlanGraphWrapper objects from InMemoryStore together with cleaning up SQLExecutionUIData
How was this patch tested?
existing unit test was extended to check also SparkPlanGraphWrapper object count
@vanzin