[SPARK-24014][PySpark] Add onStreamingStarted method to StreamingListener #21098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Apr 18, 2018
| @@ -23,6 +23,12 @@ class StreamingListener(object): | |||
| def __init__(self): | |||
| pass | |||
|
|
|||
| def onStreamingStarted(self, streamingStarted): | |||
There was a problem hiding this comment.
Although in #21057, it is mentioned that there will be an exception to be thrown if this method is lack. However, I can't reproduce such error.
There was a problem hiding this comment.
Because PythonStreamingListener have this method, I think it is still better to add it here. And I also add a test to make sure it works.
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Apr 18, 2018
|
Test build #89509 has finished for PR 21098 at commit
|
|
Merging to master and branch 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2018
…ener ## What changes were proposed in this pull request? The `StreamingListener` in PySpark side seems to be lack of `onStreamingStarted` method. This patch adds it and a test for it. This patch also includes a trivial doc improvement for `createDirectStream`. Original PR is #21057. ## How was this patch tested? Added test. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes #21098 from viirya/SPARK-24014. (cherry picked from commit 8bb0df2) Signed-off-by: jerryshao <sshao@hortonworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
StreamingListenerin PySpark side seems to be lack ofonStreamingStartedmethod. This patch adds it and a test for it.This patch also includes a trivial doc improvement for
createDirectStream.Original PR is #21057.
How was this patch tested?
Added test.