Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24548][SQL] Fix incorrect schema of Dataset with tuple encoders #21576

Closed
wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 15, 2018

What changes were proposed in this pull request?

When creating tuple expression encoders, we should give the serializer expressions of tuple items correct names, so we can have correct output schema when we use such tuple encoders.

How was this patch tested?

Added test.

@viirya viirya changed the title [SPARK-24548[SQL] Fix incorrect schema of Dataset with tuple encoders [SPARK-24548][SQL] Fix incorrect schema of Dataset with tuple encoders Jun 15, 2018
@SparkQA
Copy link

SparkQA commented Jun 15, 2018

Test build #91903 has finished for PR 21576 at commit e349448.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jun 15, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 15, 2018

Test build #91919 has finished for PR 21576 at commit e349448.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jun 15, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 15, 2018

Test build #91921 has finished for PR 21576 at commit e349448.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Jun 15, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jun 15, 2018

Test build #91932 has finished for PR 21576 at commit e349448.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Jun 15, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Jun 15, 2018

Test build #91945 has finished for PR 21576 at commit e349448.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jun 15, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 16, 2018

Test build #91951 has finished for PR 21576 at commit e349448.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jun 16, 2018

Is Jenkins unstable? The building error looks weird...

@viirya
Copy link
Member Author

viirya commented Jun 16, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 16, 2018

Test build #91953 has finished for PR 21576 at commit e349448.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jun 16, 2018

cc @cloud-fan Do you have idea about the building error message?

@viirya
Copy link
Member Author

viirya commented Jun 16, 2018

Seems the building for other PRs are also failed.

@kiszk
Copy link
Member

kiszk commented Jun 16, 2018

One of my PRs has the same problem. When tried to compile more than 20 times, only one try went into the test phase.

@viirya
Copy link
Member Author

viirya commented Jun 16, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 16, 2018

Test build #91977 has finished for PR 21576 at commit e349448.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@viirya
Copy link
Member Author

viirya commented Jun 18, 2018

@HyukjinKwon Looks it passes building now.

@SparkQA
Copy link

SparkQA commented Jun 18, 2018

Test build #92020 has finished for PR 21576 at commit e349448.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jun 18, 2018

cc @cloud-fan for review.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@asfgit asfgit closed this in 8f225e0 Jun 18, 2018
@viirya viirya deleted the SPARK-24548 branch December 27, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants