Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][SQL] Remove invalid comment from SparkStrategies #21595

Conversation

HeartSaVioR
Copy link
Contributor

What changes were proposed in this pull request?

This patch is removing invalid comment from SparkStrategies, given that TODO-like comment is no longer preferred one as the comment: #21388 (comment)

Removing invalid comment will prevent contributors to spend their times which is not going to be merged.

How was this patch tested?

N/A

* The option is no longer preferred one as below comment
  * apache#21388 (comment)
* Removing this to prevent contributors to waste their times
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @hvanhovell

@SparkQA
Copy link

SparkQA commented Jun 20, 2018

Test build #92111 has finished for PR 21595 at commit 8afb36b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

LGTM - merging to master. Thanks

@asfgit asfgit closed this in c8ef923 Jun 20, 2018
@HeartSaVioR
Copy link
Contributor Author

@HyukjinKwon @hvanhovell Thanks for reviewing and merging!

@HeartSaVioR HeartSaVioR deleted the MINOR-remove-invalid-comment-on-spark-strategies branch January 25, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants