Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-24871][SQL] Refactor Concat and MapConcat to avoid creating concatenator object for each row. #21824

Closed
wants to merge 3 commits into from
Closed

[SPARK-24871][SQL] Refactor Concat and MapConcat to avoid creating concatenator object for each row. #21824

wants to merge 3 commits into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jul 20, 2018

What changes were proposed in this pull request?

Refactor Concat and MapConcat to:

  • avoid creating concatenator object for each row.
  • make Concat handle containsNull properly.
  • make Concat shortcut if null child is found.

How was this patch tested?

Added some tests and existing tests.

@ueshin
Copy link
Member Author

ueshin commented Jul 20, 2018

cc @mn-mikke @bersprockets

@ueshin
Copy link
Member Author

ueshin commented Jul 20, 2018

also cc @cloud-fan @gatorsmile

cloud-fan
cloud-fan reviewed Jul 20, 2018
View reviewed changes
...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala Outdated
| ${CodeGenerator.getValue(s"args[y]", elementType, "z")}
|);""".stripMargin

val setterCode = if (checkForNull) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: nullSafeSetterCode

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Jul 20, 2018

Test build #93316 has finished for PR 21824 at commit 644a30d.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 20, 2018

Test build #93326 has finished for PR 21824 at commit c254523.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member Author

ueshin commented Jul 20, 2018

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 20, 2018

Test build #93330 has finished for PR 21824 at commit c254523.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@asfgit asfgit closed this in 7b6d36b Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloud-fan cloud-fan cloud-fan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ueshin @cloud-fan @SparkQA