[SPARK-25002][SQL] Avro: revise the output record namespace #21974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #94035 has finished for PR 21974 at commit
|
|
thanks, merging to master! |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
Currently the output namespace is starting with ".", e.g. `.topLevelRecord` Although it is valid according to Avro spec, we should remove the starting dot in case of failures when the output Avro file is read by other lib: linkedin/goavro#96 Unit test Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21974 from gengliangwang/avro_namespace. (cherry picked from commit f45d60a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the output namespace is starting with ".", e.g.
.topLevelRecordAlthough it is valid according to Avro spec, we should remove the starting dot in case of failures when the output Avro file is read by other lib:
linkedin/goavro#96
How was this patch tested?
Unit test