Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-25836][BUILD][K8S] For now disable kubernetes-integration-tests #22829

Closed
wants to merge 2 commits into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Oct 25, 2018

What changes were proposed in this pull request?

For now make building and running kubernetes-integration-tests manual.

How was this patch tested?

N/A

@srowen
Copy link
Member Author

srowen commented Oct 25, 2018

WDYT @erikerlandson @skonto @gatorsmile

@SparkQA
Copy link

SparkQA commented Oct 25, 2018

@SparkQA
Copy link

SparkQA commented Oct 25, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4488/

pom.xml Outdated
@@ -2656,7 +2656,8 @@
<id>kubernetes</id>
<modules>
<module>resource-managers/kubernetes/core</module>
<module>resource-managers/kubernetes/integration-tests</module>
<!-- for now, don't automatically build and run the integration tests -->
<!-- <module>resource-managers/kubernetes/integration-tests</module> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would mean it's not possible to run the integration tests at all via Maven, because the integration tests module will never be available. What about creating a separate profile, kubernetes-integration-tests, which includes both the kubernetes and the kubernetes/integration-tests module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine too. I even think this is a temporary measure, and that ideally these all live in the kubernetes module as test artifacts.

@SparkQA
Copy link

SparkQA commented Oct 25, 2018

@SparkQA
Copy link

SparkQA commented Oct 25, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4497/

@skonto
Copy link
Contributor

skonto commented Oct 25, 2018

ok seems this to be closed. I will copy it to the other PR.

@SparkQA
Copy link

SparkQA commented Oct 25, 2018

Test build #98031 has finished for PR 22829 at commit fea27cc.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 25, 2018

Test build #98042 has finished for PR 22829 at commit 8ee6b30.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen deleted the SPARK-25836 branch October 27, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants