[SPARK-26592][SS] Throw exception when kafka delegation token tried to obtain with proxy user #23511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o obtain with proxy user.
|
Test build #101033 has finished for PR 23511 at commit
|
|
retest this please |
|
Test build #101042 has finished for PR 23511 at commit
|
core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala
Show resolved
Hide resolved
|
Hi, @gaborgsomogyi . Mostly, looks correct. Only one minor comment. |
|
@dongjoon-hyun thanks for the review, addressed. |
|
Test build #101078 has finished for PR 23511 at commit
|
|
retest this please |
vanzin
reviewed
Jan 11, 2019
core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #101088 has finished for PR 23511 at commit
|
HeartSaVioR
reviewed
Jan 13, 2019
|
Test build #101141 has finished for PR 23511 at commit
|
|
Test build #101143 has finished for PR 23511 at commit
|
HyukjinKwon
reviewed
Jan 14, 2019
| @@ -78,6 +80,21 @@ class KafkaTokenUtilSuite extends SparkFunSuite with BeforeAndAfterEach { | |||
| Configuration.setConfiguration(null) | |||
| } | |||
|
|
|||
| test("checkProxyUser with proxy current user should throw exception") { | |||
| val realUser = UserGroupInformation.createUserForTesting("realUser", Array()) | |||
There was a problem hiding this comment.
not a big deal but Array() -> Array.empty[String]. Ignore this if everything in this PR is ready
|
Merging to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…o obtain with proxy user ## What changes were proposed in this pull request? Kafka is not yet support to obtain delegation token with proxy user. It has to be turned off until https://issues.apache.org/jira/browse/KAFKA-6945 implemented. In this PR an exception will be thrown when this situation happens. ## How was this patch tested? Additional unit test. Closes apache#23511 from gaborgsomogyi/SPARK-26592. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Kafka is not yet support to obtain delegation token with proxy user. It has to be turned off until https://issues.apache.org/jira/browse/KAFKA-6945 implemented.
In this PR an exception will be thrown when this situation happens.
How was this patch tested?
Additional unit test.