[SPARK-21213][SQL][FOLLOWUP] Improve partition statistics in AnalyzePartitionCommand #23584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of old table stats in AnalyzePartitionCommand
|
cc @mbasmanova @cloud-fan @gatorsmile Would you take a look if have time. :) |
| @@ -110,7 +110,7 @@ case class AnalyzePartitionCommand( | |||
| val newTotalSize = CommandUtils.calculateLocationSize( | |||
| sessionState, tableMeta.identifier, p.storage.locationUri) | |||
| val newRowCount = rowCounts.get(p.spec) | |||
| val newStats = CommandUtils.compareAndGetNewStats(tableMeta.stats, newTotalSize, newRowCount) | |||
| val newStats = CommandUtils.compareAndGetNewStats(p.stats, newTotalSize, newRowCount) | |||
There was a problem hiding this comment.
Different. Stats in tableMeta are table level stats, stats in Partition are partition level stats.
wangshuo128
changed the title
|
Also cc @wzhfy |
|
Can one of the admins verify this patch? |
|
We're closing this PR because it hasn't been updated in a while. If you'd like to revive this PR, please reopen it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr proposes to improve partition statistics in
AnalyzePartitionCommand:HiveExternalCatalog.listPartitionsandHiveExternalCatalog.listPartitionsByFilter.AnalyzePartitionCommand.Thus partitions listed in
AnalyzePartitionCommandwould contain Spark stats and would not update HiveMetaStore if stats not changed.spark/sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzePartitionCommand.scala
Line 87 in 6d9c54b
How was this patch tested?
Modified existing tests.