[SPARK-26787] Fix standardizeLabels error message in WeightedLeastSquares #23705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error message falsely states standardization=True is causing a problem, even when standardization=False. The real issue is standardizeLabels=True, which is set automatically in LinearRegression and not currently available in the Public API.
attilapiros
approved these changes
Jan 30, 2019
|
Can you fix the PR title to be more specific? |
srowen
reviewed
Jan 31, 2019
| @@ -133,7 +133,8 @@ private[ml] class WeightedLeastSquares( | |||
| return new WeightedLeastSquaresModel(coefficients, intercept, diagInvAtWA, Array(0D)) | |||
| } else { | |||
| require(!(regParam > 0.0 && standardizeLabel), "The standard deviation of the label is " + | |||
| "zero. Model cannot be regularized with standardization=true") | |||
| "zero. Model cannot be regularized with standardizeLabel=true " + | |||
| "(standardizeLabel is not exposed in the LinearRegression API)") | |||
There was a problem hiding this comment.
The second line isn't meaningful to the caller. I'd just say "Model cannot be regularized when labels are standardized".
There was a problem hiding this comment.
Good point. Since the primary way to get here is through calling LinearRegression(), I was trying to give the user a message that indicates it's a current limitation of the API, not the implementation/algorithm. I updated to your suggestion though as I do think it's an improvement over the current message of standardization=true, which was simply incorrect. Thanks for reviewing!
bscan
changed the title
Updating based on code review.
srowen
approved these changes
Jan 31, 2019
srowen
approved these changes
Jan 31, 2019
|
Test build #4540 has finished for PR 23705 at commit
|
|
Merged to master |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…ares Error message falsely states standardization=True is causing a problem, even when standardization=False. The real issue is standardizeLabels=True, which is set automatically in LinearRegression and not currently available in the Public API. ## What changes were proposed in this pull request? A simple change to an error message. More details here: https://jira.apache.org/jira/browse/SPARK-26787 ## How was this patch tested? This does not change any functionality. Closes apache#23705 from bscan/bscan-errormsg-1. Authored-by: bscan <brianjscannell@gmail.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message falsely states standardization=True is causing a problem, even when standardization=False. The real issue is standardizeLabels=True, which is set automatically in LinearRegression and not currently available in the Public API.
What changes were proposed in this pull request?
A simple change to an error message. More details here: https://jira.apache.org/jira/browse/SPARK-26787
How was this patch tested?
This does not change any functionality.