[SPARK-26871][SQL]File Source V2: avoid creating unnecessary FileIndex in the write path #23774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #23383, the file source V2 framework is implemented. In the PR,
FileIndex
is created as a member ofFileTable
, so that we can implement partition pruning like 0f9fcab in the future(As data source V2 catalog is under development, partition pruning is removed from the PR)However, after write path of file source V2 is implemented, I find that a simple write will create an unnecessary
FileIndex
, which is required byFileTable
. This is a sort of regression. And we can see there is a warning message when writing to ORC filesThis PR is to make
FileIndex
as a lazy value inFileTable
, so that we can avoid creating unnecessaryFileIndex
in the write path.How was this patch tested?
Existing unit test