[SPARK-27026][BUILD] Upgrade Docker image for release build to Ubuntu 18.04 LTS #23932
Conversation
|
I'm fine with it but maybe @felixcheung has opinions about the R stuff. |
|
Test build #102929 has finished for PR 23932 at commit
|
| # * Python/PyPandoc (2.7.12/3.5.2) | ||
| # * R-base/R-base-dev (3.3.2+) | ||
| # * Python/PyPandoc (2.7.15/3.6.7) | ||
| # * R-base/R-base-dev (3.5.0+) |
There was a problem hiding this comment.
I'm not sure - particularly whether that brings in packages that we haven't been testing with. I guess we will find out in the next RC
There was a problem hiding this comment.
FYI, we don't run R 3.5+ in Jenkins or any where
There was a problem hiding this comment.
In Ubuntu 18.04LTS, R 3.3 is no longer supported. Only R 3.5 is supported.
| @@ -38,7 +42,8 @@ ARG PIP_PKGS="pyopenssl pypandoc numpy pygments sphinx" | |||
| # | |||
| # This is all in a single "RUN" command so that if anything changes, "apt update" is run to fetch | |||
| # the most current package versions (instead of potentially using old versions cached by docker). | |||
| RUN echo 'deb http://cran.cnr.Berkeley.edu/bin/linux/ubuntu xenial/' >> /etc/apt/sources.list && \ | |||
| RUN apt-get update && $APT_INSTALL gnupg && \ | |||
There was a problem hiding this comment.
18.04 doesn't have gpg? I can see why here but nit all other places we are apt-get clean after
(though maybe unnecessary in a build image)
There was a problem hiding this comment.
gpg is not installed by default in 18.04, and I was surprised.
There was a problem hiding this comment.
LGTM. I know that @dbtsai is using this one. Yep. We can see the result at next RC vote.
|
Test build #102966 has finished for PR 23932 at commit
|
|
retest this please |
|
Test build #102971 has finished for PR 23932 at commit
|
|
Test build #103035 has finished for PR 23932 at commit
|
|
Retest this please |
|
Test build #103062 has finished for PR 23932 at commit
|
|
Retest this please |
|
Test build #103068 has finished for PR 23932 at commit
|
dongjoon-hyun
changed the title
|
Merged to master. |
| @@ -84,7 +84,7 @@ GIT_REF=${GIT_REF:-master} | |||
|
|
|||
| RELEASE_STAGING_LOCATION="https://dist.apache.org/repos/dist/dev/spark" | |||
|
|
|||
| GPG="gpg -u $GPG_KEY --no-tty --batch" | |||
| GPG="gpg -u $GPG_KEY --no-tty --batch --pinentry-mode loopback" | |||
There was a problem hiding this comment.
I noticed the failures on Jenkins job spark-master-package: https://amplab.cs.berkeley.edu/jenkins/view/Spark%20Packaging/job/spark-master-package/2275/console
It seems to be related to this change.
gpg: invalid option "--pinentry-mode"
Deleting credential directory /home/jenkins/workspace/spark-master-package/spark-utils/new-release-scripts/jenkins/jenkins-credentials-tVKlQBOF
Build step 'Execute shell' marked build as failure
[WS-CLEANUP] Deleting project workspace...[WS-CLEANUP] done
Finished: FAILURE
There was a problem hiding this comment.
Opened https://issues.apache.org/jira/browse/SPARK-27984 to track it.
What changes were proposed in this pull request?
Upgrade Docker image for release build to Ubuntu 18.04LTS
How was this patch tested?
Manually tested.