[MINOR][BUILD] Update genjavadoc to 0.13 #24443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #104833 has finished for PR 24443 at commit
|
|
Argh .. |
|
(I assume it won't work until your other change is in.) |
|
Thanks for the investigation! |
|
Test build #104840 has finished for PR 24443 at commit
|
|
Uh ok that's bad news. Genjavadoc update may not fly |
|
Test build #104843 has finished for PR 24443 at commit
|
|
OK, that worked. I think the new genjavadoc fixes some spurious warnings but uncovers some more, but then I just worked around them in the docs. |
|
LGTM Merged to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 19, 2019
…er upgrading genjavadoc to 0.14 ### What changes were proposed in this pull request? This PR backport #24443 to fix java doc generation after upgrading genjavadoc to 0.14. ### Why are the changes needed? Fix javadoc generation issue. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? ``` ./build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos clean test:package streaming-kinesis-asl-assembly/assembly ./build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos unidoc ``` Closes #25841 from wangyum/genjavadoc-0.13-branch-2.4. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Kind of related to gatorsmile#5 - let's update genjavadoc to see if it generates fewer spurious javadoc errors to begin with.
How was this patch tested?
Existing docs build