New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28683][BUILD][FOLLOW-UP][2.4] Fix javadoc generation issue after upgrading genjavadoc to 0.14 #25841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if tests pass.
Oh. I see. Thanks! Let me check it manually, too. |
BTW, @wangyum . Is the build error correct? In your previous backporting PR and current |
Got it. The following?
|
I can reproduce it by: build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pflume -Pkinesis-asl -Pyarn -Pkafka-0-8 -Pspark-ganglia-lgpl -Phive -Pmesos unidoc |
Yes. I noticed that from the previous PRs. I updated the PR title and description more specifically~ |
Thank you @dongjoon-hyun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. I also verified this in branch-2.4
.
I'll merge this because this is verified manually and currently blocks the other backporting PR. |
…er upgrading genjavadoc to 0.14 ### What changes were proposed in this pull request? This PR backport #24443 to fix java doc generation after upgrading genjavadoc to 0.14. ### Why are the changes needed? Fix javadoc generation issue. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? ``` ./build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos clean test:package streaming-kinesis-asl-assembly/assembly ./build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos unidoc ``` Closes #25841 from wangyum/genjavadoc-0.13-branch-2.4. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Test build #110958 has finished for PR 25841 at commit
|
What changes were proposed in this pull request?
This PR backport #24443 to fix java doc generation after upgrading genjavadoc to 0.14.
Why are the changes needed?
Fix javadoc generation issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?