[SPARK-28029][SQL][TEST] Port int2.sql #24853
Conversation
|
|
||
| -- check rounding when casting from numeric | ||
| SELECT x, smallint(x) AS int2_value | ||
| FROM (VALUES decimal(-2.5), |
There was a problem hiding this comment.
We do not have numeric type, can we use decimal?
There was a problem hiding this comment.
I plan to use DecimalType.SYSTEM_DEFAULT:
|
Test build #106425 has finished for PR 24853 at commit
|
wangyum
changed the title
|
Test build #106520 has finished for PR 24853 at commit
|
|
Test build #106535 has finished for PR 24853 at commit
|
|
Retest this please. |
| -- !query 6 schema | ||
| struct<five:string,f1:smallint> | ||
| -- !query 6 output | ||
| -1234 |
There was a problem hiding this comment.
Ur, is this our test framework behavior? The first column seems to be gone.
There was a problem hiding this comment.
Yes. This is the behavior if replace '' to '#':
| SELECT '' AS three, i.* FROM INT2_TBL i WHERE (i.f1 % int('2')) = smallint('0'); | ||
|
|
||
| -- [SPARK-28024] Incorrect value when out of range | ||
| SELECT '' AS five, i.f1, i.f1 * smallint('2') AS x FROM INT2_TBL i; |
There was a problem hiding this comment.
Let's comment out line 68 since this should throw ERROR: smallint out of range.
| SELECT '' AS five, i.f1, i.f1 * int('2') AS x FROM INT2_TBL i; | ||
|
|
||
| -- [SPARK-28024] Incorrect value when out of range | ||
| SELECT '' AS five, i.f1, i.f1 + smallint('2') AS x FROM INT2_TBL i; |
There was a problem hiding this comment.
ditto for this due to ERROR: smallint out of range.
| SELECT '' AS five, i.f1, i.f1 + int('2') AS x FROM INT2_TBL i; | ||
|
|
||
| -- [SPARK-28024] Incorrect value when out of range | ||
| SELECT '' AS five, i.f1, i.f1 - smallint('2') AS x FROM INT2_TBL i; |
There was a problem hiding this comment.
ditto due to ERROR: smallint out of range
| SELECT '' AS five, i.f1, i.f1 - int('2') AS x FROM INT2_TBL i; | ||
|
|
||
| -- The result is different because [SPARK-2659] | ||
| SELECT '' AS five, i.f1, i.f1 / smallint('2') AS x FROM INT2_TBL i; |
There was a problem hiding this comment.
In case of SPARK-2659, we already made a decision and will not change. So, let's use div' instead of /. I believe this is the same reason why we use smallint('2')instead ofint2 '2'`
There was a problem hiding this comment.
The description should be adjusted accordingly like this.
- The result is different because [SPARK-2659]
+ PostgreSQL `/` is the same with Spark `div` since SPARK-2659.
| SELECT '' AS five, i.f1, i.f1 / smallint('2') AS x FROM INT2_TBL i; | ||
|
|
||
| -- The result is different because [SPARK-2659] | ||
| SELECT '' AS five, i.f1, i.f1 / int('2') AS x FROM INT2_TBL i; |
|
Test build #107391 has finished for PR 24853 at commit
|
|
Test build #107395 has finished for PR 24853 at commit
|
|
Test build #107390 has finished for PR 24853 at commit
|
|
retest this please |
|
Test build #107398 has finished for PR 24853 at commit
|
What changes were proposed in this pull request?
This PR is to port int2.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/int2.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/int2.out
When porting the test cases, found two PostgreSQL specific features that do not exist in Spark SQL:
SPARK-28023: Trim the string when cast string type to other types
SPARK-28027: Add bitwise shift left/right operators
Also, found a bug:
SPARK-28024: Incorrect value when out of range
Also, found three inconsistent behavior:
SPARK-27923: Invalid input syntax for smallint throws exception at PostgreSQL
SPARK-28028: Cast numeric to integral type need round
SPARK-2659: HiveQL: Division operator should always perform fractional division, for example:
How was this patch tested?
N/A