-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test #25278
Conversation
Test build #108267 has finished for PR 25278 at commit
|
retest this please |
Test build #108276 has finished for PR 25278 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @huaxingao and @viirya .
Merged to master.
I understand the intention, @huaxingao . But, SPARK-28441 should have enabled this test in the PR together. I changed this to as a follow-up of SPARK-28441. |
Oh, I missed @HyukjinKwon 's comment. |
Thanks! @dongjoon-hyun @viirya |
Ah, for trackabiliy, maybe 28441 was a better choice but should be fine either way. |
Either is fine to me. |
What changes were proposed in this pull request?
Fix for
SPARK-28441 (PythonUDF used in correlated scalar subquery causes UnsupportedOperationException)
is in. Re-enable the commented out test forudf(max(udf(column)))
How was this patch tested?
use existing test
udf-except.sql