Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test #25278

Closed
wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Fix for SPARK-28441 (PythonUDF used in correlated scalar subquery causes UnsupportedOperationException) is in. Re-enable the commented out test for udf(max(udf(column)))

How was this patch tested?

use existing test udf-except.sql

@SparkQA
Copy link

SparkQA commented Jul 28, 2019

Test build #108267 has finished for PR 25278 at commit d4562e9.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Jul 28, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Jul 28, 2019

Test build #108276 has finished for PR 25278 at commit d4562e9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @huaxingao and @viirya .
Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test [SPARK-28441][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test Jul 28, 2019
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jul 28, 2019

I understand the intention, @huaxingao . But, SPARK-28441 should have enabled this test in the PR together. I changed this to as a follow-up of SPARK-28441.

@dongjoon-hyun
Copy link
Member

Oh, I missed @HyukjinKwon 's comment.
Okay, I change the PR title back.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28441][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test [SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test Jul 28, 2019
@huaxingao
Copy link
Contributor Author

Thanks! @dongjoon-hyun @viirya

@HyukjinKwon
Copy link
Member

Ah, for trackabiliy, maybe 28441 was a better choice but should be fine either way.

@viirya
Copy link
Member

viirya commented Jul 29, 2019

Either is fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants