Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28789][DOCS][SQL] Document ALTER DATABASE command #25523

Closed
wants to merge 7 commits into from

Conversation

dilipbiswal
Copy link
Contributor

@dilipbiswal dilipbiswal commented Aug 21, 2019

What changes were proposed in this pull request?

Document ALTER DATABSE statement in SQL Reference Guide.

Why are the changes needed?

Currently Spark lacks documentation on the supported SQL constructs causing
confusion among users who sometimes have to look at the code to understand the
usage. This is aimed at addressing this issue.

Does this PR introduce any user-facing change?

Yes.

Before:
There was no documentation for this.

After.
Screen Shot 2019-08-28 at 1 51 13 PM
Screen Shot 2019-08-28 at 1 51 27 PM

How was this patch tested?

Tested using jykyll build --serve

@dilipbiswal
Copy link
Contributor Author

cc @gatorsmile

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109465 has finished for PR 25523 at commit b0e4c64.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor Author

@HyukjinKwon Hello... had a question. Would you know why these PRs are not getting linked to the corresponding JIRA ?

@@ -18,5 +18,23 @@ license: |
See the License for the specific language governing permissions and
limitations under the License.
---
### Description
You can author metadata associated with a database by setting the `DBPROPERTIES`. Using this command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "the" before DBPROPERTIES here and below?
And maybe back-tick SCHEMA and DATABASE.

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109512 has finished for PR 25523 at commit 4b70e0c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal dilipbiswal changed the title [SPARK-28789][DOC] Document ALTER DATABASE command [SPARK-28789][DOCS][SQL] Document ALTER DATABASE command Aug 24, 2019
@HyukjinKwon
Copy link
Member

Hey, @dilipbiswal. sorry for late response. Seems linked fine now :D.

@SparkQA
Copy link

SparkQA commented Aug 28, 2019

Test build #109882 has finished for PR 25523 at commit 3eb967c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 28, 2019

Test build #109883 has finished for PR 25523 at commit ffa449f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

LGTM

Thanks! Merged to master.

@dilipbiswal
Copy link
Contributor Author

Thank you very much @gatorsmile @srowen

@SparkQA
Copy link

SparkQA commented Aug 29, 2019

Test build #109886 has finished for PR 25523 at commit 843f705.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

shivusondur added a commit to shivusondur/spark that referenced this pull request Sep 17, 2019
Handled PR according to apache#25523 PR which is already merged.
to make uniform accross all docs
shivusondur added a commit to shivusondur/spark that referenced this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants