Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28788][DOC][SQL]Document ANALYZE TABLE statement in SQL Reference #25524

Closed
wants to merge 5 commits into from

Conversation

huaxingao
Copy link
Contributor

@huaxingao huaxingao commented Aug 21, 2019

What changes were proposed in this pull request?

Document ANALYZE TABLE statement in SQL Reference

Why are the changes needed?

To complete SQL reference

Does this PR introduce any user-facing change?

Yes

Before:
There was no documentation for this.

After:
image

image

image

How was this patch tested?

Tested using jykyll build --serve

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109467 has finished for PR 25524 at commit 9fd9e2b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor

@huaxingao Could you please attach a screenshot of the page ?

**This page is under construction**
### Description

ANALYZE TABLE statement can be used to collect statistics about the table. The information can be used by the query optimizer to find a better plan.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back-tick the reserved words for clarity.
plan -> query plan? maybe query execution plan?

@srowen
Copy link
Member

srowen commented Aug 21, 2019

Oh, I realize now you are just copying the Databricks documentation? https://docs.databricks.com/spark/latest/spark-sql/language-manual/analyze-table.html I don't think we can do that, or at least, will have to seek permission. @gatorsmile did we discuss this separately with the docs team at Databricks and that's the idea or was the idea to create simple, separate documentation from scratch?

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109521 has finished for PR 25524 at commit 1016212.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109530 has finished for PR 25524 at commit a5516bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 30, 2019

Test build #109959 has finished for PR 25524 at commit 9cc9be0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

@dilipbiswal @srowen @gatorsmile
Could you please review? Thanks!

<dd>
<ul>
<li> If no analyze option is specified, <code>ANALYZE TABLE</code> collects the table's number of rows and size in bytes. </li>
<li> NOSCAN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huaxingao will it read better if we bold this ?

@dilipbiswal
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Sep 3, 2019

Test build #110064 has finished for PR 25524 at commit 5584f48.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor

Looks good to me
cc @gatorsmile

@gatorsmile
Copy link
Member

LGTM

Thanks! Merged to master

@gatorsmile gatorsmile closed this in 56f2887 Sep 3, 2019
@huaxingao
Copy link
Contributor Author

@dilipbiswal @gatorsmile @srowen Thank you all for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants