[SPARK-28780][ML][2.3] deprecate LinearSVCModel.setWeightCol #25546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
|
friendly ping @dongjoon-hyun @srowen |
|
Test build #109545 has finished for PR 25546 at commit
|
|
Test build #109546 has finished for PR 25546 at commit
|
dongjoon-hyun
changed the title
dongjoon-hyun
requested changes
Aug 22, 2019
There was a problem hiding this comment.
This should be consistent with 2.4 backporting PR, @zhengruifeng .
|
Test build #109559 has finished for PR 25546 at commit
|
dongjoon-hyun
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
+1, LGTM. Merged to branch-2.3.
cc @kiszk since he is a release manager of 2.3.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 22, 2019
### What changes were proposed in this pull request? deprecate `LinearSVCModel.setWeightCol`, and make it a no-op ### Why are the changes needed? `LinearSVCModel` should not provide this setter, moreover, this method is wrongly defined. ### Does this PR introduce any user-facing change? no, this method is only deprecated ### How was this patch tested? existing suites Closes #25546 from zhengruifeng/svc_model_deprecate_setWeight. Authored-by: zhengruifeng <ruifengz@foxmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
deprecate
LinearSVCModel.setWeightCol, and make it a no-opWhy are the changes needed?
LinearSVCModelshould not provide this setter, moreover, this method is wrongly defined.Does this PR introduce any user-facing change?
no, this method is only deprecated
How was this patch tested?
existing suites