Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28083][SQL][TEST][FOLLOW-UP] Enable LIKE ... ESCAPE test cases #26949

Closed
wants to merge 3 commits into from
Closed

[SPARK-28083][SQL][TEST][FOLLOW-UP] Enable LIKE ... ESCAPE test cases #26949

wants to merge 3 commits into from

Conversation

beliefer
Copy link
Contributor

What changes were proposed in this pull request?

This PR is a follow-up to #25001

Why are the changes needed?

No

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass the Jenkins with the newly update test files.

@beliefer beliefer changed the title [WIP][SPARK-28083][SQL][TEST][FOLLOW-UP] Enable LIKE ... ESCAPE test cases [SPARK-28083][SQL][TEST][FOLLOW-UP] Enable LIKE ... ESCAPE test cases Dec 19, 2019
@SparkQA
Copy link

SparkQA commented Dec 19, 2019

Test build #115566 has finished for PR 26949 at commit 8a05583.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -272,53 +272,53 @@ SELECT 'indio' NOT LIKE 'in_o' AS `true`;

-- [SPARK-28083] ANSI SQL: LIKE predicate: ESCAPE clause
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

@maropu maropu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the @dongjoon-hyun comment.

@SparkQA
Copy link

SparkQA commented Dec 20, 2019

Test build #115591 has finished for PR 26949 at commit 6342b98.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.
Thank you, @beliefer and @maropu .

@beliefer
Copy link
Contributor Author

@dongjoon-hyun @maropu Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants