Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-28083][SQL][TEST][FOLLOW-UP] Enable LIKE ... ESCAPE test cases #26949

Closed
wants to merge 3 commits into from
Closed

[SPARK-28083][SQL][TEST][FOLLOW-UP] Enable LIKE ... ESCAPE test cases #26949

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ad28f2
uncomment like escape test cases
beliefer Dec 19, 2019
8a05583
add result
beliefer Dec 19, 2019
6342b98
Remove comment
beliefer Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions sql/core/src/test/resources/sql-tests/inputs/postgreSQL/strings.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,53 +272,53 @@ SELECT 'indio' NOT LIKE 'in_o' AS `true`;

-- [SPARK-28083] ANSI SQL: LIKE predicate: ESCAPE clause
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

-- unused escape character
-- SELECT 'hawkeye' LIKE 'h%' ESCAPE '#' AS "true";
-- SELECT 'hawkeye' NOT LIKE 'h%' ESCAPE '#' AS "false";
SELECT 'hawkeye' LIKE 'h%' ESCAPE '#' AS `true`;
SELECT 'hawkeye' NOT LIKE 'h%' ESCAPE '#' AS `false`;

-- SELECT 'indio' LIKE 'ind_o' ESCAPE '$' AS "true";
-- SELECT 'indio' NOT LIKE 'ind_o' ESCAPE '$' AS "false";
SELECT 'indio' LIKE 'ind_o' ESCAPE '$' AS `true`;
SELECT 'indio' NOT LIKE 'ind_o' ESCAPE '$' AS `false`;

-- escape character
-- E061-05 like predicate with escape clause
-- SELECT 'h%' LIKE 'h#%' ESCAPE '#' AS "true";
-- SELECT 'h%' NOT LIKE 'h#%' ESCAPE '#' AS "false";
SELECT 'h%' LIKE 'h#%' ESCAPE '#' AS `true`;
SELECT 'h%' NOT LIKE 'h#%' ESCAPE '#' AS `false`;

-- SELECT 'h%wkeye' LIKE 'h#%' ESCAPE '#' AS "false";
-- SELECT 'h%wkeye' NOT LIKE 'h#%' ESCAPE '#' AS "true";
SELECT 'h%wkeye' LIKE 'h#%' ESCAPE '#' AS `false`;
SELECT 'h%wkeye' NOT LIKE 'h#%' ESCAPE '#' AS `true`;

-- SELECT 'h%wkeye' LIKE 'h#%%' ESCAPE '#' AS "true";
-- SELECT 'h%wkeye' NOT LIKE 'h#%%' ESCAPE '#' AS "false";
SELECT 'h%wkeye' LIKE 'h#%%' ESCAPE '#' AS `true`;
SELECT 'h%wkeye' NOT LIKE 'h#%%' ESCAPE '#' AS `false`;

-- SELECT 'h%awkeye' LIKE 'h#%a%k%e' ESCAPE '#' AS "true";
-- SELECT 'h%awkeye' NOT LIKE 'h#%a%k%e' ESCAPE '#' AS "false";
SELECT 'h%awkeye' LIKE 'h#%a%k%e' ESCAPE '#' AS `true`;
SELECT 'h%awkeye' NOT LIKE 'h#%a%k%e' ESCAPE '#' AS `false`;

-- SELECT 'indio' LIKE '_ndio' ESCAPE '$' AS "true";
-- SELECT 'indio' NOT LIKE '_ndio' ESCAPE '$' AS "false";
SELECT 'indio' LIKE '_ndio' ESCAPE '$' AS `true`;
SELECT 'indio' NOT LIKE '_ndio' ESCAPE '$' AS `false`;

-- SELECT 'i_dio' LIKE 'i$_d_o' ESCAPE '$' AS "true";
-- SELECT 'i_dio' NOT LIKE 'i$_d_o' ESCAPE '$' AS "false";
SELECT 'i_dio' LIKE 'i$_d_o' ESCAPE '$' AS `true`;
SELECT 'i_dio' NOT LIKE 'i$_d_o' ESCAPE '$' AS `false`;

-- SELECT 'i_dio' LIKE 'i$_nd_o' ESCAPE '$' AS "false";
-- SELECT 'i_dio' NOT LIKE 'i$_nd_o' ESCAPE '$' AS "true";
SELECT 'i_dio' LIKE 'i$_nd_o' ESCAPE '$' AS `false`;
SELECT 'i_dio' NOT LIKE 'i$_nd_o' ESCAPE '$' AS `true`;

-- SELECT 'i_dio' LIKE 'i$_d%o' ESCAPE '$' AS "true";
-- SELECT 'i_dio' NOT LIKE 'i$_d%o' ESCAPE '$' AS "false";
SELECT 'i_dio' LIKE 'i$_d%o' ESCAPE '$' AS `true`;
SELECT 'i_dio' NOT LIKE 'i$_d%o' ESCAPE '$' AS `false`;

-- escape character same as pattern character
-- SELECT 'maca' LIKE 'm%aca' ESCAPE '%' AS "true";
-- SELECT 'maca' NOT LIKE 'm%aca' ESCAPE '%' AS "false";
SELECT 'maca' LIKE 'm%aca' ESCAPE '%' AS `true`;
SELECT 'maca' NOT LIKE 'm%aca' ESCAPE '%' AS `false`;

-- SELECT 'ma%a' LIKE 'm%a%%a' ESCAPE '%' AS "true";
-- SELECT 'ma%a' NOT LIKE 'm%a%%a' ESCAPE '%' AS "false";
SELECT 'ma%a' LIKE 'm%a%%a' ESCAPE '%' AS `true`;
SELECT 'ma%a' NOT LIKE 'm%a%%a' ESCAPE '%' AS `false`;

-- SELECT 'bear' LIKE 'b_ear' ESCAPE '_' AS "true";
-- SELECT 'bear' NOT LIKE 'b_ear' ESCAPE '_' AS "false";
SELECT 'bear' LIKE 'b_ear' ESCAPE '_' AS `true`;
SELECT 'bear' NOT LIKE 'b_ear' ESCAPE '_' AS `false`;

-- SELECT 'be_r' LIKE 'b_e__r' ESCAPE '_' AS "true";
-- SELECT 'be_r' NOT LIKE 'b_e__r' ESCAPE '_' AS "false";
SELECT 'be_r' LIKE 'b_e__r' ESCAPE '_' AS `true`;
SELECT 'be_r' NOT LIKE 'b_e__r' ESCAPE '_' AS `false`;

-- SELECT 'be_r' LIKE '__e__r' ESCAPE '_' AS "false";
-- SELECT 'be_r' NOT LIKE '__e__r' ESCAPE '_' AS "true";
SELECT 'be_r' LIKE '__e__r' ESCAPE '_' AS `false`;
SELECT 'be_r' NOT LIKE '__e__r' ESCAPE '_' AS `true`;

-- [SPARK-28448] Implement ILIKE operator
--
Expand Down
Loading