Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30813][ML] Fix Matrices.sprand comments #27564

Closed
wants to merge 2 commits into from

Conversation

xwu99
Copy link
Contributor

@xwu99 xwu99 commented Feb 13, 2020

What changes were proposed in this pull request?

Fix mistakes in comments

Why are the changes needed?

There are mistakes in comments

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@xwu99 xwu99 changed the title [SPARK-30813][ML] Fix MLlib Matrices.sprand comments [SPARK-30813][ML] Fix Matrices.sprand comments Feb 13, 2020
@srowen
Copy link
Member

srowen commented Mar 2, 2020

Jenkins test this please

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK pending tests

@SparkQA
Copy link

SparkQA commented Mar 2, 2020

Test build #119146 has finished for PR 27564 at commit 8cb472e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in ac12276 Mar 2, 2020
srowen pushed a commit that referenced this pull request Mar 2, 2020
### What changes were proposed in this pull request?
Fix mistakes in comments

### Why are the changes needed?
There are mistakes in comments

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
N/A

Closes #27564 from xwu99/fix-mllib-sprand-comment.

Authored-by: Wu, Xiaochang <xiaochang.wu@intel.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
(cherry picked from commit ac12276)
Signed-off-by: Sean Owen <srowen@gmail.com>
@srowen
Copy link
Member

srowen commented Mar 2, 2020

Merged to master/3.0/2.4

srowen pushed a commit that referenced this pull request Mar 2, 2020
### What changes were proposed in this pull request?
Fix mistakes in comments

### Why are the changes needed?
There are mistakes in comments

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
N/A

Closes #27564 from xwu99/fix-mllib-sprand-comment.

Authored-by: Wu, Xiaochang <xiaochang.wu@intel.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
(cherry picked from commit ac12276)
Signed-off-by: Sean Owen <srowen@gmail.com>
sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
### What changes were proposed in this pull request?
Fix mistakes in comments

### Why are the changes needed?
There are mistakes in comments

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
N/A

Closes apache#27564 from xwu99/fix-mllib-sprand-comment.

Authored-by: Wu, Xiaochang <xiaochang.wu@intel.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants