-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-30968][BUILD] Upgrade aws-java-sdk-sts to 1.11.655 #27720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test build #119016 has finished for PR 27720 at commit
|
retest this please |
Test build #119025 has finished for PR 27720 at commit
|
retest this please |
Test build #119040 has finished for PR 27720 at commit
|
Retest this please. |
<aws.kinesis.client.version>1.12.0</aws.kinesis.client.version> | ||
<!-- Should be consistent with Kinesis client dependency --> | ||
<aws.java.sdk.version>1.11.271</aws.java.sdk.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a comment reminding to change aws.java.sdk.version
too in front of aws.kinesis.client.version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. For now, <!-- Should be consistent with Kinesis client dependency -->
at line 151 looks enough to me. Although one line ahead (in front of
) sounds better than one line below, the warning content will be the same.
Test build #119054 has finished for PR 27720 at commit
|
Thank you all! Merged to |
### What changes were proposed in this pull request? This PR aims to upgrade `aws-java-sdk-sts` to `1.11.655`. ### Why are the changes needed? [SPARK-29677](#26333) upgrades AWS Kinesis Client to 1.12.0 for Apache Spark 2.4.5 and 3.0.0. Since AWS Kinesis Client 1.12.0 is using AWS SDK 1.11.665, `aws-java-sdk-sts` should be consistent with Kinesis client dependency. - https://github.com/awslabs/amazon-kinesis-client/releases/tag/v1.12.0 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins. Closes #27720 from dongjoon-hyun/SPARK-30968. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 3995728) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
### What changes were proposed in this pull request? This PR aims to upgrade `aws-java-sdk-sts` to `1.11.655`. ### Why are the changes needed? [SPARK-29677](#26333) upgrades AWS Kinesis Client to 1.12.0 for Apache Spark 2.4.5 and 3.0.0. Since AWS Kinesis Client 1.12.0 is using AWS SDK 1.11.665, `aws-java-sdk-sts` should be consistent with Kinesis client dependency. - https://github.com/awslabs/amazon-kinesis-client/releases/tag/v1.12.0 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins. Closes #27720 from dongjoon-hyun/SPARK-30968. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 3995728) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun @viirya @HyukjinKwon @maropu I am not sure I get the rational of merging this into 2.4. We are bumping the version for a spark maintenance branch to include almost two years of aws sdk changes, which is very risky. I am worried about unexpected behavior changes. |
Also, newer version of aws sdk uses apache httpclient, 4.5.9, what is the reason we do not upgrade httpclient? |
Hi, @yhuai . I'm wondering if you are suggesting to revert SPARK-29677 from
|
@dongjoon-hyun sorry for getting back late. What I mean is that 1.11.655 depends on apache httpclient 4.5.9. This pr does not upgrade httpclient. Was there a specific reason? |
### What changes were proposed in this pull request? This PR aims to upgrade `aws-java-sdk-sts` to `1.11.655`. ### Why are the changes needed? [SPARK-29677](apache#26333) upgrades AWS Kinesis Client to 1.12.0 for Apache Spark 2.4.5 and 3.0.0. Since AWS Kinesis Client 1.12.0 is using AWS SDK 1.11.665, `aws-java-sdk-sts` should be consistent with Kinesis client dependency. - https://github.com/awslabs/amazon-kinesis-client/releases/tag/v1.12.0 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins. Closes apache#27720 from dongjoon-hyun/SPARK-30968. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
This PR aims to upgrade
aws-java-sdk-sts
to1.11.655
.Why are the changes needed?
SPARK-29677 upgrades AWS Kinesis Client to 1.12.0 for Apache Spark 2.4.5 and 3.0.0.
Since AWS Kinesis Client 1.12.0 is using AWS SDK 1.11.665,
aws-java-sdk-sts
should be consistent with Kinesis client dependency.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins.