Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment #28267

Closed
wants to merge 2 commits into from
Closed

[MINOR][DOCS] Fix a typo in ContainerPlacementStrategy's class comment #28267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a1d7c
fix a typo in LocalityPreferredContainerPlacementStrategy's class com…
asclepiusaka Apr 20, 2020
94ee145
fix typoes in LocalityPreferredContainerPlacementStrategy's class com…
asclepiusaka Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...main/scala/org/apache/spark/deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private[yarn] case class ContainerLocalityPreferences(nodes: Array[String], rack
* and cpus per task is 1, so the required container number is 15,
* and host ratio is (host1: 30, host2: 30, host3: 20, host4: 10).
*
* 1. If requested container number (18) is more than the required container number (15):
* 1. If the requested container number (18) is more than the required container number (15):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this the

*
* requests for 5 containers with nodes: (host1, host2, host3, host4)
* requests for 5 containers with nodes: (host1, host2, host3)
Expand All @@ -63,16 +63,16 @@ private[yarn] case class ContainerLocalityPreferences(nodes: Array[String], rack
* follow the method of 1 and 2.
*
* 4. If containers exist and some of them can match the requested localities.
* For example if we have 1 containers on each node (host1: 1, host2: 1: host3: 1, host4: 1),
* For example if we have 1 container on each node (host1: 1, host2: 1: host3: 1, host4: 1),
* and the expected containers on each node would be (host1: 5, host2: 5, host3: 4, host4: 2),
* so the newly requested containers on each node would be updated to (host1: 4, host2: 4,
* host3: 3, host4: 1), 12 containers by total.
*
* 4.1 If requested container number (18) is more than newly required containers (12). Follow
* method 1 with updated ratio 4 : 4 : 3 : 1.
* method 1 with an updated ratio 4 : 4 : 3 : 1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this an can be removed too.

*
* 4.2 If request container number (10) is more than newly required containers (12). Follow
* method 2 with updated ratio 4 : 4 : 3 : 1.
* 4.2 If request container number (10) is less than newly required containers (12). Follow
* method 2 with an updated ratio 4 : 4 : 3 : 1.
*
* 5. If containers exist and existing localities can fully cover the requested localities.
* For example if we have 5 containers on each node (host1: 5, host2: 5, host3: 5, host4: 5),
Expand Down