Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3982] [Streaming] [PySpark] Python API: receiverStream() #2833

Closed
wants to merge 5 commits into from

Conversation

davies
Copy link
Contributor

@davies davies commented Oct 17, 2014

This patch brings receiverStream() for Python API, it could be used to create an input stream with any arbitrary user implemented receiver.

The Python receiver depends on py4j, so can only be run in driver (locally).

cc @tdas

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have started for PR 2833 at commit 3b7b407.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have finished for PR 2833 at commit 3b7b407.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Receiver(object):
    • >>> class MyReceiver(Receiver):

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21830/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have started for PR 2833 at commit 3b7b407.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have started for PR 2833 at commit 118279b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have finished for PR 2833 at commit 118279b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Receiver(object):
    • >>> class MyReceiver(Receiver):

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21849/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

Tests timed out for PR 2833 at commit 3b7b407 after a configured wait of 120m.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have started for PR 2833 at commit 118279b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 17, 2014

QA tests have finished for PR 2833 at commit 118279b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Receiver(object):
    • >>> class MyReceiver(Receiver):

@theoryno3
Copy link

Just wondering when this pull request will be accepted?

@tdas
Copy link
Contributor

tdas commented Oct 21, 2014

Taking a detailed look right now.

@SparkQA
Copy link

SparkQA commented Oct 22, 2014

QA tests have started for PR 2833 at commit d523fbf.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 22, 2014

Tests timed out for PR 2833 at commit d523fbf after a configured wait of 120m.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22017/
Test FAILed.

@giwa
Copy link
Contributor

giwa commented Oct 27, 2014

@tdas CC @davies
If this feature is ready for 1.2 release, it would be great! Could you take a look why this test fails in Jenkins since code freeze for 1.2 is November 1st?

@SparkQA
Copy link

SparkQA commented Oct 27, 2014

Test build #480 has started for PR 2833 at commit d523fbf.

  • This patch merges cleanly.

@davies
Copy link
Contributor Author

davies commented Oct 27, 2014

@giwa In this PR, the Python receiver can only run in driver, so it's not as scalable as scala one (which run in executor). In order to let it run in executor, there a bunch things needed to do, so this maybe can not catch the 1.2 release.

@tdas Could you update a little bit about your plan?

@SparkQA
Copy link

SparkQA commented Oct 27, 2014

Test build #480 has finished for PR 2833 at commit d523fbf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Receiver(object):
    • >>> class MyReceiver(Receiver):

@tdas
Copy link
Contributor

tdas commented Dec 25, 2014

@davies Let's focus on this after Kafka Python API gets in. Since doing this the right way (that is running the receiver in the executor) is complicated, lets do a design doc and discussion on this.

In the meantime, I leave it up to you to decide whether you want to leave this PR open.

@davies
Copy link
Contributor Author

davies commented Dec 29, 2014

@tdas I think we could leave this PR open as a proposed approach, discuss the pro/con in docs.

@tdas
Copy link
Contributor

tdas commented Dec 29, 2014

Alright, then could you come write up a design doc, post it on the JIRA and then we can discuss on it?

Conflicts:
	streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
@SparkQA
Copy link

SparkQA commented Dec 29, 2014

Test build #24871 has started for PR 2833 at commit 3eb0d9f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 30, 2014

Test build #24872 has started for PR 2833 at commit 38c6342.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 30, 2014

Test build #24871 has finished for PR 2833 at commit 3eb0d9f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class GaussianMixtureModel(
    • class Receiver(object):
    • >>> class MyReceiver(Receiver):

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24871/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 30, 2014

Test build #24872 has finished for PR 2833 at commit 38c6342.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class GaussianMixtureModel(
    • class Receiver(object):
    • >>> class MyReceiver(Receiver):

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24872/
Test PASSed.

@tdas
Copy link
Contributor

tdas commented Mar 23, 2015

@davies Since we are not working on this feature any more mind closing this PR? We can open it once when we decide to focus on it.

@davies davies closed this Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants