[SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Fix Hadoop-3.2 profile UT failure #28550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
commented
May 16, 2020
| @@ -262,7 +264,7 @@ class ClientSuite extends SparkFunSuite with Matchers { | |||
| when(appContext.getUnmanagedAM).thenReturn(true) | |||
|
|
|||
| val rmAppManager = new RMAppManager(rmContext, | |||
| null, | |||
| mock(classOf[YarnScheduler]), | |||
There was a problem hiding this comment.
Without this, NPE occurs at this.scheduler of Hadoop code.
|
Test build #122699 has finished for PR 28550 at commit
|
dongjoon-hyun
changed the title
|
Retest this please |
|
Test build #122701 has finished for PR 28550 at commit
|
This was referenced May 16, 2020
This reverts commit 8b74398.
HyukjinKwon
approved these changes
May 16, 2020
|
Oh, @HyukjinKwon . It seems that there is still issue (maybe at the last commit.) Sorry. |
This comment has been minimized.
This comment has been minimized.
dongjoon-hyun
changed the title
|
I converted this PR into the Draft since this is flaky. |
This comment has been minimized.
This comment has been minimized.
|
Test build #122708 has finished for PR 28550 at commit
|
|
Test build #122709 has finished for PR 28550 at commit
|
dongjoon-hyun
changed the title
|
Retest this please |
|
Test build #122711 has finished for PR 28550 at commit
|
|
Test build #122712 has finished for PR 28550 at commit
|
|
Test build #122713 has finished for PR 28550 at commit
|
|
It seems that I was confused because my local reproducer is not the same with Jenkins. For now, this has the same limitation with the previous reverted commit. I'll close this for now and revisit later. |
|
Test build #122706 has finished for PR 28550 at commit
|
|
Test build #122714 has finished for PR 28550 at commit
|
dongjoon-hyun
added a commit
that referenced
this pull request
May 16, 2020
…ific type` in Hadoop-3.2 ### What changes were proposed in this pull request? This PR aims to recover Hadoop-3.2 profile jobs on `master` branch by disabling a UT added by SPARK-31235 in Hadoop 3.2 temporarily. The target UT is not a flaky test. It always fail on Hadoop-3.2 profile currently although it works in Hadoop 2.7 profile. So, in this PR, we keep the test coverage in Hadoop 2.7 and ignore the test in Hadoop 3.2 temporarily to unblock the other PRs. ### Why are the changes needed? SPARK-31235 added a test case which is breaking Hadoop 3.2 and there are two follow-up to fix it. Although two follow-ups can fix the UT in Hadoop 3.2 environment. The side-effect on Hadoop classes cause some random UT failures in the other suites. - #28456 - #28550 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the Jenkins with SBT/Maven. Closes #28552 from dongjoon-hyun/SPARK-31235-2. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix a UT failure in
Hadoop-3.2profile.Why are the changes needed?
Currently,
masterbranch Hadoop-3.2 profile jobs (SBT/Maven) are broken due to the consistent UT failure.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with Hadoop 3.2 profile (SBT/Maven).