Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-31235][TESTS][FOLLOWUP] Disable test case specify a more specific type in Hadoop-3.2 #28552

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 16, 2020

What changes were proposed in this pull request?

This PR aims to recover Hadoop-3.2 profile jobs on master branch by disabling a UT added by SPARK-31235 in Hadoop 3.2 temporarily. The target UT is not a flaky test. It always fail on Hadoop-3.2 profile currently although it works in Hadoop 2.7 profile. So, in this PR, we keep the test coverage in Hadoop 2.7 and ignore the test in Hadoop 3.2 temporarily to unblock the other PRs.

Why are the changes needed?

SPARK-31235 added a test case which is breaking Hadoop 3.2 and there are two follow-up to fix it. Although two follow-ups can fix the UT in Hadoop 3.2 environment. The side-effect on Hadoop classes cause some random UT failures in the other suites.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins with SBT/Maven.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-31235][TESTS][FOLLOWUP] Disable test case `specify a more spec… [SPARK-31235][TESTS][FOLLOWUP] Disable test case specify a more specific type in Hadoop-3.2 May 16, 2020
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-31235][TESTS][FOLLOWUP] Disable test case specify a more specific type in Hadoop-3.2 [SPARK-31235][TESTS][FOLLOWUP][test-hadoop3.2] Disable test case specify a more specific type in Hadoop-3.2 May 16, 2020
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented May 16, 2020

Test build #122730 has finished for PR 28552 at commit c91e0a3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 16, 2020

Test build #122731 has finished for PR 28552 at commit c91e0a3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 16, 2020

Test build #122732 has finished for PR 28552 at commit c91e0a3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-31235][TESTS][FOLLOWUP][test-hadoop3.2] Disable test case specify a more specific type in Hadoop-3.2 [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Disable test case specify a more specific type in Hadoop-3.2 May 16, 2020
@dongjoon-hyun
Copy link
Member Author

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @srowen .

@SparkQA
Copy link

SparkQA commented May 16, 2020

Test build #122733 has finished for PR 28552 at commit c91e0a3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-31235][TESTS][FOLLOWUP][test-maven][test-hadoop3.2] Disable test case specify a more specific type in Hadoop-3.2 [SPARK-31235][TESTS][FOLLOWUP] Disable test case specify a more specific type in Hadoop-3.2 May 16, 2020
@HyukjinKwon
Copy link
Member

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-31235-2 branch May 18, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants