[SPARK-31849][PYTHON][SQL][FOLLOW-UP] More correct error message in Python UDF exception message #28762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @ueshin. I am going to merge since there's no CI test but I tested manually. |
|
Merged to master and branch-3.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Jun 9, 2020
…ython UDF exception message ### What changes were proposed in this pull request? This PR proposes to fix wordings in the Python UDF exception error message from: From: > An exception was thrown from Python worker in the executor. The below is the Python worker stacktrace. To: > An exception was thrown from the Python worker. Please see the stack trace below. It removes "executor" because Python worker is technically a separate process, and remove the duplicated wording "Python worker" . ### Why are the changes needed? To give users better exception messages. ### Does this PR introduce _any_ user-facing change? No, it's in unreleased branches only. If RC3 passes, yes, it will change the exception message. ### How was this patch tested? Manually tested. Closes #28762 from HyukjinKwon/SPARK-31849-followup-2. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit e289140) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
late LGTM |
|
Thank you @maropu! |
|
Test build #123663 has finished for PR 28762 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix wordings in the Python UDF exception error message from:
From:
To:
It removes "executor" because Python worker is technically a separate process, and remove the duplicated wording "Python worker" .
Why are the changes needed?
To give users better exception messages.
Does this PR introduce any user-facing change?
No, it's in unreleased branches only. If RC3 passes, yes, it will change the exception message.
How was this patch tested?
Manually tested.