[SPARK-31944] Add instance weight support in LinearRegressionSummary #28772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #123706 has finished for PR 28772 at commit
|
|
Test build #123709 has finished for PR 28772 at commit
|
srowen
reviewed
Jun 10, 2020
| if (!privateModel.isDefined(privateModel.weightCol) || privateModel.getWeightCol.isEmpty) { | ||
| lit(1.0) | ||
| } else { | ||
| checkNonNegativeWeight(col(privateModel.getWeightCol).cast(DoubleType)) |
There was a problem hiding this comment.
Is this check needed -- would the regression implementation have already checked it? OK if not.
There was a problem hiding this comment.
You are right. This has already been checked. I will remove.
|
Test build #123781 has finished for PR 28772 at commit
|
|
Merged to master |
|
Thanks Sean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add instance weight support in LinearRegressionSummary
Why are the changes needed?
LinearRegression and RegressionMetrics support instance weight. We should support instance weight in LinearRegressionSummary too.
Does this PR introduce any user-facing change?
No
How was this patch tested?
add new test