[SPARK-32021][SQL] Increase precision of seconds and fractions of make_interval
#28873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dongjoon-hyun @juliuszsompolski Please, review this PR. |
|
Test build #124297 has finished for PR 28873 at commit
|
|
Thank you for pinging me, @MaxGekk . |
|
Test build #124301 has finished for PR 28873 at commit
|
dongjoon-hyun
approved these changes
Jun 20, 2020
|
Could you make a backporting PR to branch-3.0? We need to regenerate some files. |
MaxGekk
added a commit
to MaxGekk/spark
that referenced
this pull request
Jun 20, 2020
…ke_interval` Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long). To improve UX of Spark SQL. Yes - Add tests to IntervalExpressionsSuite - Add an example to the `MakeInterval` expression - Add tests to `interval.sql` Closes apache#28873 from MaxGekk/make_interval-sec-precision. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
@dongjoon-hyun This is the backport #28878 |
rajatahujaatinmobi
pushed a commit
to rajatahujaatinmobi/spark-1
that referenced
this pull request
Jun 27, 2020
…ke_interval` Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long). To improve UX of Spark SQL. Yes - Add tests to IntervalExpressionsSuite - Add an example to the `MakeInterval` expression - Add tests to `interval.sql` Closes apache#28873 from MaxGekk/make_interval-sec-precision. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> [SPARK-31957][SQL] Cleanup hive scratch dir for the developer api startWithContext Comparing to the long-running ThriftServer via start-script, we are more likely to hit the issue https://issues.apache.org/jira/browse/HIVE-10415 / https://issues.apache.org/jira/browse/SPARK-31626 in the developer API `startWithContext` This PR apply SPARK-31626 to the developer API `startWithContext` Fix the issue described in SPARK-31626 Yes, the hive scratch dir will be deleted if cleanup is enabled for calling `startWithContext` new test Closes apache#28784 from yaooqinn/SPARK-31957. Authored-by: Kent Yao <yaooqinn@hotmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> [SPARK-32039][YARN][WEBUI][Master] Adding Check to not to set UI port (spark.ui.port) property if mentioned explicitly [SPARK-32039][YARN][WEBUI][Master] Adding Check to not to set UI port (spark.ui.port) property if mentioned explicitly Merge branch 'ahujarajat261/SPARK-32039-change-yarn-webui-port-range-with-property-latest-spark' of https://github.com/rajatahujaatinmobi/spark-1 into ahujarajat261/SPARK-32039-change-yarn-webui-port-range-with-property-latest-spark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long).
Why are the changes needed?
To improve UX of Spark SQL.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
MakeIntervalexpressioninterval.sql