[SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of make_interval
#28878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke_interval` Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long). To improve UX of Spark SQL. Yes - Add tests to IntervalExpressionsSuite - Add an example to the `MakeInterval` expression - Add tests to `interval.sql` Closes apache#28873 from MaxGekk/make_interval-sec-precision. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Test build #124319 has finished for PR 28878 at commit
|
dongjoon-hyun
approved these changes
Jun 20, 2020
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 20, 2020
…f `make_interval` ### What changes were proposed in this pull request? Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long). ### Why are the changes needed? To improve UX of Spark SQL. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? - Add tests to IntervalExpressionsSuite - Add an example to the `MakeInterval` expression - Add tests to `interval.sql` Authored-by: Max Gekk max.gekkgmail.com Signed-off-by: Dongjoon Hyun dongjoonapache.org (cherry picked from commit 66ba356) Closes #28878 from MaxGekk/make_interval-sec-precision-3.0. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long).
Why are the changes needed?
To improve UX of Spark SQL.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
MakeIntervalexpressioninterval.sqlAuthored-by: Max Gekk max.gekk@gmail.com
Signed-off-by: Dongjoon Hyun dongjoon@apache.org
(cherry picked from commit 66ba356)