[SPARK-32156][TESTS][SQL] Refactor two similar test cases from SPARK-31061 in HiveExternalCatalogSuite #28980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TJX2014
commented
Jul 2, 2020
| val parquetTable = CatalogTable( | ||
| identifier = TableIdentifier("parq_tbl", Some("db1")), | ||
| tableType = CatalogTableType.MANAGED, | ||
| storage = storageFormat.copy(locationUri = Some(new URI("file:/some/path"))), |
There was a problem hiding this comment.
file:/some/path seems not very suitable.
TJX2014
commented
Jul 2, 2020
| val rawTable = externalCatalog.getTable("db1", "parq_tbl") | ||
| assert(rawTable.provider === Some("parquet")) | ||
|
|
||
| val fooTable = parquetTable.copy(provider = Some("foo")) |
There was a problem hiding this comment.
Seems we should use rawTableget from catalog instead of parquetTable from the beginning.
HyukjinKwon
reviewed
Jul 2, 2020
| catalog.alterTable(fooTable) | ||
| val alteredTable = externalCatalog.getTable("db1", "parq_tbl") | ||
| assert(alteredTable.provider === Some("foo")) | ||
| Seq("parquet", "hive").foreach(i => { |
There was a problem hiding this comment.
nit: foreach(i => { -> foreach { provider =>
HyukjinKwon
changed the title
cloud-fan
approved these changes
Jul 2, 2020
|
ok to test |
HyukjinKwon
approved these changes
Jul 2, 2020
|
Test build #124900 has finished for PR 28980 at commit
|
dongjoon-hyun
approved these changes
Jul 2, 2020
|
Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1.Merge two similar tests for SPARK-31061 and make the code clean.
2.Fix table alter issue due to lose path.
Why are the changes needed?
Because this two tests for SPARK-31061 is very similar and could be merged.
And the first test case should use
rawTableinstead ofparquetTableto alter.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test.