[SPARK-32220][SQL][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result #29084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Jul 13, 2020
| // Since for join hint [[SHUFFLE_REPLICATE_NL]] when having equi join conditions, | ||
| // we still choose Cartesian Product Join, but in ExtractEquiJoinKeys, it will filter | ||
| // out equi condition. Instead of using the condition extracted by ExtractEquiJoinKeys, | ||
| // we should use the original join condition "j.condition". |
There was a problem hiding this comment.
how about:
`CartesianProductExec` can't implicitly evaluate the equal join condition, here we should
pass the original condition which includes both equal and non-equal conditions.
There was a problem hiding this comment.
how about:
`CartesianProductExec` can't implicitly evaluate the equal join condition, here we should pass the original condition which includes both equal and non-equal conditions.
Updated
cloud-fan
approved these changes
Jul 13, 2020
|
Test build #125754 has finished for PR 29084 at commit
|
|
retest this please |
|
Test build #125757 has finished for PR 29084 at commit
|
gatorsmile
approved these changes
Jul 13, 2020
dongjoon-hyun
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
+1, LGTM. Thank you, @AngersZhuuuu and all.
Merged to master.
|
Could you make a backporting PR to branch-3.0, @AngersZhuuuu ? |
|
Test build #125771 has finished for PR 29084 at commit
|
Sure, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
follow comment #29035 (comment)
Explain for pr
Why are the changes needed?
add comment
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not need